Repository navigation
fix(specs): name the WAF Conditions class instead of referencing it - #14267
Conversation
|
Review complete. No issues found. This change teaches the OpenAPI3 spec formatter to map a validator class to the correct string-typed schema, mirroring an equivalent case already present in the GraphQL type mapper.
Reviewed commit: 1e33b77 |
🟢 Tier S · Ready to merge
The GraphQL mapper and OpenAPI3 formatter now match the WAF Conditions validator by its fully qualified class-name string, avoiding a direct reference to a dependency unavailable in CE. The OpenAPI3 comment for array-typed Multiple validators was also updated to describe the emitted item schema.
📂 Walkthrough · 2
Reviewed |
utopia-php/waf is not a dependency of this repository, so PHPStan reports Utopia\WAF\Validator\Conditions::class as an unknown class. Matching on the class name string keeps the case without the reference.
1e33b77 to
7941952
Compare
Security rulesScan did not complete. Posted by |
#14266 added
Utopia\WAF\Validator\Conditions::classto OpenAPI3 and the GraphQL mapper.utopia-php/wafisn't a dependency of this repository, so PHPStan reports it asclass.notFound. The case now matches the class name as a string. That's the same comparison, sinceget_class()returns that string, and it doesn't reference a class that isn't installed. It also makes theMultiplecomment generic.Related: appwrite-labs/cloud#6413