fix: keep the HTTP status on API errors without a JSON Status body

[abnegate]

Summary

MakesHttpCalls::call() built KubernetesAPIException with $errorPayload['code'] ?? 0. A 4xx whose body is not a JSON Status therefore came back with code 0: the HTTP status was lost and the Guzzle exception was not chained. The API server answers that way for an API group or resource it does not serve. For example, GET /apis/snapshot.storage.k8s.io/v1/…/volumesnapshots/… on a cluster without the VolumeSnapshot CRDs answers a plain-text 404 page not found, and every getCode() === 404 check misses it, K8sResource::exists() included.

Edge impact: on kind clusters without the snapshot CRDs, edge's branch cleanup read that 404 as a hard failure (code 0) instead of "absent". It left orphan branch namespaces behind and failed cloud's CI.

Changes

• KubernetesAPIException::from(BadResponseException) builds the exception in one place:
  • code: the Status body's code when it's a positive int, so JSON Status bodies behave as before. Otherwise the HTTP status. A Status code of 0 means unset.
  • payload: the decoded body when it's a JSON object, as before. Otherwise null.
  • previous: the Guzzle exception.
• MakesHttpCalls::call() and ChecksClusterVersion::loadClusterVersion() now use it. They were the only two places that wrapped a Guzzle ClientException this way.
• PhpK8sException::__construct() takes an optional trailing ?Throwable $previous, so existing callers are unaffected. It also passes '' instead of null to Exception, because PHP 8.1+ deprecates null there.

Behaviour notes

• JSON Status errors keep the same code and payload.
• K8sResource::exists() now returns false for a resource under an API group the cluster doesn't serve. Before, it threw a code-0 KubernetesAPIException.
• For edge, after it bumps appwrite-labs/php-k8s (it pins dev-main):
  • Pooler::transient() deliberately retries code-0 errors, and its docblock describes the old behaviour. A non-Status 4xx will now carry its real status and be treated as definitive.
  • The '404 Not Found' message fallback in NamespaceIdentity::absent() becomes redundant.

Tests

• tests/MakesHttpCallsTest.php (unit): a Guzzle MockHandler drives call() through a getClient() override, TestCase::clusterRespondingWith(). Each case uses a different HTTP status and body code, so the tests show which one wins:
  • A 400 response with a Status body code: 409 gives code 409, because the body wins. The payload comes through unchanged.
  • A 404 response with a Status body code: 0 gives code 404, because a zero body code falls back to the HTTP status. The payload comes through unchanged.
  • A text/plain 404 page not found gives code 404, a null payload and a chained ClientException.
• tests/ChecksClusterVersionTest.php (unit): a text/plain 403 from /version gives code 403 and a chained ClientException.
• tests/MakesHttpCallsIntegrationTest.php (integration, runs on minikube in CI): a GET under an unserved API group raises a KubernetesAPIException with code 404. It uses the same setUp() guard as the other live tests, so a local run without a cluster skips it.

Red/green:

• Before the src/ change, the plain-text cases fail with Failed asserting that 0 is identical to 404. and … 0 is identical to 403.. After it, they pass.
• Making from() always return the HTTP status fails the body-wins case with Failed asserting that 400 is identical to 409.
• Dropping the zero-code check fails the fallback case with Failed asserting that 0 is identical to 404.

Local checks (PHP 8.5, no cluster, no ext-yaml):

• pint --test passes.
• psalm reports the same 571 issues before and after this change. They're mostly unused-code findings, and CI doesn't run Psalm.
• phpunit:
  • All new unit tests pass, and the new integration test skips without a cluster.
  • Every failure also happens on main: 95 tests need a cluster and 61 need ext-yaml.

🤖 Generated with Claude Code

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Changes how API errors preserve HTTP status codes.

The PR appears safe to merge; no outstanding findings remain.

Summary

The PR preserves the HTTP status for API errors without a usable JSON Status code, retains decoded payloads, and chains the underlying Guzzle exception.

• Adds focused unit tests for fallback and Status-code precedence.
• Moves the live unserved-API-group check into a guarded integration test.

_{Reviews (2) · Last reviewed commit: "test: pin exception code precedence and ..."}