fix: send propagationPolicy at the top level of DeleteOptions

[abnegate]

Problem

RunsClusterOperations::delete() claims to support propagationPolicy, but it never reaches the Kubernetes API. Two stacked bugs:

1. propagationPolicy and gracePeriodSeconds were nested inside the preconditions map, where the API ignores them (preconditions only accepts uid and resourceVersion).
2. The $this->refresh() call that followed setAttribute('preconditions', ...) replaces the resource attributes entirely (syncWith() assigns $this->attributes), so even the misplaced fields were wiped before serialization. The actual body sent was the refreshed resource relabelled as kind: DeleteOptions:

{
    "apiVersion": "batch/v1",
    "kind": "DeleteOptions",
    "metadata": {
        "name": "reap",
        "uid": "...",
        "resourceVersion": "12345",
        "namespace": "default"
    }
}

No propagationPolicy anywhere, so Job deletes fall back to the API default for batch/v1 (Orphan). This is the root cause of the DAT-1869 reopen: edge's resize reap calls $job->delete(propagationPolicy: 'Foreground'), the delete orphans the Completed pods (no ownerRef, no TTL), pvc-protection never releases the claim, and the resize wedges permanently.

Fix

Build the DeleteOptions payload explicitly instead of mutating the resource. New body:

{
    "apiVersion": "v1",
    "kind": "DeleteOptions",
    "propagationPolicy": "Foreground",
    "preconditions": {
        "uid": "..."
    }
}

• propagationPolicy and gracePeriodSeconds (when set) are top-level DeleteOptions fields.
• preconditions carries only the resource uid, guarding against deleting a recreated resource of the same name.
• The resourceVersion precondition is dropped deliberately: it never took effect before (see bug 2), and enforcing it now would introduce conflict failures into every consumer's delete path whenever a controller bumps the resource between refresh() and the DELETE call.
• The payload builder is extracted to deleteOptions() so the shape is unit-testable without a cluster.

Tests

tests/DeleteOptionsTest.php asserts the payload shape: propagationPolicy at the top level (and not in preconditions), gracePeriodSeconds at the top level when set, preconditions limited to uid and omitted when the uid is unknown, and no resource attributes leaking into the body.

Consumers

Edge's dedicated-database resize reap depends on this fix; the edge-side bump should happen after this merges and a release is tagged.

🤖 Generated with Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge; the latest changes correctly fix ordered response handling in the request-recording test helper, and no outstanding findings remain.

Summary

This PR fixes Kubernetes deletion options so propagation policy and grace period are transmitted as top-level fields while UID remains the sole precondition.

• Adds a validated PropagationPolicy enum while preserving compatible string inputs.
• Builds an explicit Kubernetes DeleteOptions payload rather than mutating resource attributes.
• Adds request-level regression coverage for the actual DELETE body.
• Makes integration deletion checks wait for foreground deletion to complete.
• Updates the recording test cluster to preserve response ordering across multiple requests.
• Documents the updated deletion contract and foreground behavior.

_{Reviews (4) · Last reviewed commit: "test: keep one response queue per record..."}