Repository navigation
Ensure dynamic facts are updated if scheduled upgrade is removed - #100
Merged
Merged
Conversation
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
|
🚀 Merging this PR will release Merging will trigger workflows 🛠️ Auto tagging enabled with label |
haasad
force-pushed
the
fix/update-dynamic-facts
branch
from
August 3, 2026 08:38
7e32e5b to
604ed0c
Compare
HappyTetrahedron
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #99 (comment) we discussed that "re-setting" the dynamic facts is not strictly necessary. However we didn't consider the scenario where a version overlay is removed (e.g. to postpone/cancel a minor upgrade). Then the wrong dynamic fact will stay active. That's not intended and highly confusing.
This PR sets the dynamic facts
openshiftNextMinorDateandopenshiftNextMinorVersionto empty strings, when there's no scheduled, upcoming minor upgrade.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.