Skip to content

SwiftQUIC: Bugfix in inboundShortheader #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agnosticdev merged 3 commits into from
Jul 29, 2026
+10 −1
Merged

SwiftQUIC: Bugfix in inboundShortheader #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1207257
SwiftQUIC: Bugfix in inboundShortheader
agnosticdev Jul 26, 2026
45bce81
Do not directly use memcmp on InlineArray
agnosticdev Jul 26, 2026
7abbf67
Removed comment
agnosticdev Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SwiftNetwork/QUIC/QUICConnection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2307,7 +2307,7 @@ public final class QUICConnection: ManyToManyApplicationStreamProtocol,
)

guard
packet.destinationConnectionID == path.dcid
packet.destinationConnectionID == path.scid
|| validateDCIDFromInboundPacket(packet, on: path)
else {
return false
Expand Down
9 changes: 9 additions & 0 deletions Sources/SwiftNetwork/QUIC/QUICConnectionID.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,14 @@ public struct QUICConnectionID: Sendable, Equatable, CustomStringConvertible {
guard lhs.actualLength == rhs.actualLength else {
return false
}
#if !NETWORK_EMBEDDED
return lhs.connectionIDStorage.span.withUnsafeBytes { left in
rhs.connectionIDStorage.span.withUnsafeBytes { right in
memcmp(left.baseAddress!, right.baseAddress!, 20)
}
} == 0
#else
// Fall back to comparing by index
let lhsSpan = lhs._connectionID.span
let rhsSpan = rhs._connectionID.span
for i in 0..<lhs.actualLength {
Expand All @@ -176,6 +184,7 @@ public struct QUICConnectionID: Sendable, Equatable, CustomStringConvertible {
}
}
return true
#endif
}
}

Expand Down
Loading