Repository navigation
Adopt /swiftlang CI workflows - #536
Open
kukushechkin wants to merge 6 commits into
Open
kukushechkin wants to merge 6 commits into
kukushechkin wants to merge 6 commits into
Conversation
kukushechkin
marked this pull request as ready for review
November 13, 2026 11:59
rnro
reviewed
Nov 13, 2026
| enable_macos_swiftly: false | ||
| enable_freebsd: false | ||
|
|
||
| release-builds: |
Contributor
There was a problem hiding this comment.
If you want you can roll this into the above block like:
linux_command: |
Debug-Test: swift test
Release-Build: swift build -c release
windows_command: |
Debug-Test: swift test
Release-Build: swift build -c release
They will be broken out into separate jobs because they are labeled (Foo: bar)
rnro
reviewed
Nov 13, 2026
| windows_command: | | ||
| Debug-Test: | ||
| command: swift test -Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable | ||
| versions: ["current-2", "current-1", "current"] |
Contributor
There was a problem hiding this comment.
These should be selected by default, is that not working?
Contributor
Author
There was a problem hiding this comment.
The old swift-nio based behavior is different commands (with/without -warnings-as-errors) and the default seems to include all 5.
Contributor
Author
There was a problem hiding this comment.
Command diff should be more visible now with a shared var.
rnro
reviewed
Nov 13, 2026
| Debug-Test: swift test | ||
| Release-Build: swift build -c release | ||
| windows_env_vars: '{"COMMON_SWIFT_FLAGS": "--explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable"}' | ||
| windows_command: | |
Contributor
There was a problem hiding this comment.
I think this should get you equivalent jobs created:
linux_command: |
Debug-Test: swift test
Release-Build: swift build -c release
windows_command: |
Debug-Test: swift test
Release-Build: swift build -c release
windows_use_docker: true
linux_version_overrides: |
default: -Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable
nightly-release: --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable
nightly-main: --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable
windows_version_overrides: |
default: -Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable
nightly-release: --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable
nightly-main: --explicit-target-dependency-import-check error -Xswiftc -require-explicit-sendable
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from swift-nio to swiftlang CI workflows. As there is no tag yet available, let's use the latest hash for now.
Motivation:
Modernize and unify workflows with swiftlang.
Modifications:
CI configuration updated.
Result:
No swift-nio references in CI workflows.
Additionally, Swift tools version triplet is now supported to unblock #534