Repository navigation
feat: expose elementResponseAttributes via Element#cached - #726
Closed
hoanle0126 wants to merge 1 commit into
Closed
hoanle0126 wants to merge 1 commit into
hoanle0126 wants to merge 1 commit into
Conversation
Member
|
Thank you for creating this PR. I wanted to reduce the bridge implementation, so I made similar one as #727 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When
shouldUseCompactResponsesis set tofalseandelementResponseAttributesis configured on the Appium server,find_elementandfind_elementsresponses include the requested attributes alongside the element ID.This PR updates
Appium::Core::Base::Bridge(find_element_by,find_elements_by,active_element, andconvert_to_element) to pass those response attributes intoAppium::Core::Elementand exposes them viaAppium::Core::Element#cached(Appium::Core::Element::Cache), following the design discussed in #698 without storing client-side state from subsequent attribute calls.Fixes #698
Testing
bundle exec rake rubocopbundle exec rake steepUNIT_TEST=true bundle exec rake test:unitUNIT_TEST=true APPIUM_DRIVER=espresso bundle exec rake test:unit:androidUNIT_TEST=true APPIUM_DRIVER=appium bundle exec rake test:unit