Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findElementswithUiSelector.classNameMatchesenumerates parent-relative child indices, which can omit matches under different parents or return no results when the first matching child has a nonzero index. Enumerate matching instances instead, while retaining explicitinstance(n)selectors.Ports the combined change from appium/appium-uiautomator2-server#803 into
packages/uiautomator2-server, including the original fix from appium/appium-uiautomator2-server#801 with its authorship preserved.The regression tests use an activity confined to the
e2eTestflavor, containing two parents with labels at index 0 and buttons at index 1. They check complete regex results across parents, results when no match has index 0, and explicit instance selection. The new test class is included inscripts/e2e.sh, so the existing API 26/29/32/36 functional CI matrix runs it.Validation:
git diff --checkandbash -n packages/uiautomator2-server/scripts/e2e.shpass.lintE2eTestDebugalso completes successfully.