[janicduplessis]

Description

The 1.23.1 version commit. It ships #4079 (the build worker runs install, prebuild, pods and xcodebuild on the Node the project pins) and #4080 (an owned iOS simulator is muted only after SpringBoard has started). #4065 and #2850 are Desktop-only and not listed.

Patch, not minor: both commits are fixes. #4079 also adds match to stim doctor --json's toolchain.projectNode, an addition RELEASE.md section 1 would call minor; it only reports the fix's own fallback, and 1.20.2 shipped a new setting in a patch.

QA: the maintainer authorized a stable release without the pre-tag QA gate on 2026-10-20, as for 1.22.0 and 1.23.0. That waives only RELEASE.md section 3. Neither fix has been through QA: the full QA round run today on main at c132bb1 (no regressions against v1.21.0) predates #4079 and #4080. docs/releases/1.23.1.md records that round, what was omitted and what ran. Exact-commit CI, tarball inspection and the Release workflow gates stay required.

Solution

• pnpm run release:prep 1.23.1 bumps the twelve package manifests.
• docs/releases/1.23.1.md: Fixes, QA.
• apps/mobile/src/generated/licenses.json regenerated (only the @stim-cli/core version moves).

After publish:

• desktop-v0.2.4 is tagged on this PR's squash commit, so Desktop bundles the 1.23.1 server and ships feat: expire workspace cards and dismiss all notices #4065 and desktop: make sidebar filter transparent with circular hover #2850.
• An offloaded tlon-apps Android build on janics-mac-mini checks fix: run offloaded build steps on the project's pinned Node #4079 on the released packages; the result goes on this PR.

Test plan

• pnpm test: 2 failures in 2 files at load average 24 to 30, so not a local pass; CI is the gate. Rerun alone, hosted-ios-client.test.ts passed (81/81); scripts/agent-benchmark/macos-processes.test.mjs fails at sandbox-exec on this Mac, as in 1.21.0 to 1.23.0.
• Passed locally: format:check, lint, build, typecheck, knip, release:prep --check, test:runtime, test:e2e (116/116), CLI --version = 1.23.1, --help, guide agent, apps/mobile licenses:check and format:check.
• pnpm tarball inspection of all twelve packages: README and LICENSE in each, version 1.23.1, internal deps ^1.23.1 / 1.23.1, no workspace: range, file counts equal to 1.23.0's.
• Not run: test:compat (needs a connected iPhone), and the QA matrix rows, by the waiver above.

[janicduplessis]

Fresh review of 3b5c291 (1.23.1 version commit).

Actionable (1):

1. docs/releases/1.23.1.md, first Fixes bullet: "On iOS it writes that Node as NODE_BINARY in the project's .xcode.env.local" is imprecise. useXcodeNode in packages/stim-cli/src/offload/worker.ts (3b53096) writes the first node on the worker's PATH on every offloaded iOS build, not only when a pin exists. When the project pins nothing, or the worker's own node already fits the pin, that is the worker's node, not a pinned one. It also rewrites every existing export NODE_BINARY= line in the file. So an unpinned iOS project now gets its .xcode.env.local rewritten, and that is not stated. Suggested wording: "On iOS it writes the Node first on the worker's PATH (the pinned Node when one was put there) as NODE_BINARY in the project's .xcode.env.local, replacing any existing NODE_BINARY line, for every offloaded iOS build." (guide settings and website/docs/remote-machines.md from fix: run offloaded build steps on the project's pinned Node #4079 have the same loose wording; those are not part of this PR.)

Checked and correct:

• Version: 1.23.1 is defensible. git log v1.23.0..origin/main has four commits: fix: run offloaded build steps on the project's pinned Node #4079 and fix: mute an owned iOS simulator only after SpringBoard has started #4080 (fixes) and desktop: make sidebar filter transparent with circular hover #2850 and feat: expire workspace cards and dismiss all notices #4065 (Desktop only; git diff --name-only v1.23.0 c132bb118 shows only apps/desktop). The match field on toolchain.projectNode is an addition to doctor --json, which section 1 would call minor, but it only reports the fix's own fallback. 1.20.2 shipped workspace.hidden and a gc --json field in a patch. The PR body states this reasoning.
• Notes versus code: the other claims in both Fixes bullets and the SpringBoard bullet match the code in 3b53096 and f349af1 (30 s wait on com.apple.springboard.finishedstartup, could-not-mute warning on read failure or timeout, match "exact"|"major"|null, _N Cellar suffix parsing, dependency marker node <major>, deps-failed/prebuild-failed reasons, parent-directory pin lookup up to the checkout root). Package attributions are right. All three commit SHAs resolve, and iOS simulator mute does not hold: volume returns to 60 seconds after Stim confirms 'simulator muted' #4075 and A warm Gradle daemon on the build worker runs React Native's node calls on the Node it started with #4081 exist.
• QA section: it states that the c132bb1 round predates both fixes and did not exercise the mute fix or the worker's pinned Node. It lists the eight omitted rows and the two native suites, and it names the deviation from section 3. The 27 / 11 / 16 counts are the pre-bump candidate: release-qa-matrix.mjs v1.23.0 on this HEAD shows 41 / 11 / 30, and the 14 extra paths are the 12 package.json files, the notes and licenses.json.
• Diff versus origin/main: twelve package.json version bumps (1.23.0 to 1.23.1 only), docs/releases/1.23.1.md, and apps/mobile/src/generated/licenses.json (only the @stim-cli/core version). pnpm run release:prep --check: 12 packages at 1.23.1, 23 inter-package ranges, all workspace:.
• PR body matches the diff. No review: needs-human category applies to a version-and-notes diff.

Minor:

• The mute bullet does not link iOS simulator mute does not hold: volume returns to 60 seconds after Stim confirms 'simulator muted' #4075 and the pinned-Node bullet does not link Offloaded builds run dependency install and native steps on the worker's Node instead of the project's pinned Node #4077. Only the QA section mentions iOS simulator mute does not hold: volume returns to 60 seconds after Stim confirms 'simulator muted' #4075.
• The pinned-Node bullet says the worker "puts the Node that ... pins first on PATH"; it does so only when the worker's node on PATH does not already fit the pin.
• CI on this commit was still pending at review time. The PR is a draft, and I did not add review: ai-approved or mark it ready because of finding 1. Once the notes are fixed (a push removes any approval, so a new fresh review is needed), the rest is clear.

[janicduplessis]

Fresh review of 01dbb7d (1.23.1 version commit).

No actionable findings.

• The earlier finding is fixed. The first Fixes bullet now says the worker puts an installed Node first on PATH only when its own node does not fit the pin. It also says that on every offloaded iOS build, pinned or not, the worker writes the first node on its PATH as NODE_BINARY in .xcode.env.local, replacing any existing export NODE_BINARY= line. That matches useProjectNode and useXcodeNode in packages/stim-cli/src/offload/worker.ts (3b53096).
• Fixes #4077 and Fixes #4075 links were added; both issues exist. The matrix counts now read 41 / 11 / 30, matching node scripts/release-qa-matrix.mjs v1.23.0 on this head.
• The change since 3b5c291 is only docs/releases/1.23.1.md. Against origin/main the diff is still twelve package.json version bumps, the notes file and apps/mobile/src/generated/licenses.json. pnpm run release:prep --check passes (12 packages at 1.23.1, 23 workspace: ranges).
• The rest of the earlier review stands: version choice, Fixes claims versus the code, the QA section's wording about what the c132bb1 round did and did not cover, and the PR body versus the diff. No review: needs-human category applies.

CI on this head was still pending at review time; the required checks and merge gate remain the gate for merging.

[janicduplessis]

Exact-commit record for 2c23f24 (squash of this PR, tagged v1.23.1):

• Dispatched CI 39456975044: test (node 22), test (node 24), published runtime (node 22.12.0) and test (windows) passed before the tag. windows-full is recorded, not gated (1.21.1 Windows patch: remove Windows quarantines and stabilize windows-full #3878).
• Push CI 39456901894: test (node 24) failed once on packages/ci/src/__tests__/command.test.ts:69 (cancellation test still saw the killed descendant), which this diff does not touch. Filed as Flaky: packages/ci cancellation test sees the killed descendant still alive #4084. A rerun of the failed job on the same SHA passed.
• Release 39458611595: tag-on-main, publish and smoke passed. npm serves all twelve packages at 1.23.1 on latest with provenance. Local smoke (npx stim@1.23.1 --version, guide agent, tarball README, stim-server --version, stim-ci --version) passed.
• Release-notes wording follow-up for the guide and website: Docs: worker's .xcode.env.local NODE_BINARY write is described as pinned-only #4085.

[janicduplessis]

Post-publish check of #4079: offloaded tlon-apps builds on janics-mac-mini with npm 1.23.1 on both Macs (build 57b6091a6f886871).

• Worker Node: both platforms logged deps Node 22.23.2 from /opt/homebrew/opt/node@22/bin, for .nvmrc 22.22.0 (no install has 22.22.0; the newest 22.x not older than it). pnpm install --frozen-lockfile --filter tlon-mobile... completed with no gyp errors.
• iOS: the worker wrote export NODE_BINARY='/opt/homebrew/opt/node@22/bin/node' to ios/.xcode.env.local, the linked keg rather than a Cellar path.
• No build completed on the mini, for reasons outside fix: run offloaded build steps on the project's pinned Node #4079:
  • Android: the first run hit fingerprint-mismatch because the gitignored apps/tlon-mobile/.env.local feeds app.config.ts locally and is not synced. Filed Offloaded Expo build refused with fingerprint-mismatch when app config reads a gitignored .env.local #4092. With that file removed from my worktree, Gradle ran for 6m52s on the mini, then :app:buildNotificationServiceJsBundle failed because the worker's filtered install skips packages/scripts. Filed Build worker's filtered pnpm install misses workspace packages the native build runs (tlon-apps Android) #4094; it is pre-existing since 1.22.0.
  • iOS: refused with fingerprint-mismatch, because gitignored build leftovers under ios/ count locally and Podfile.lock changed in the worker's pod install. Added to Offloaded Expo build refused with fingerprint-mismatch when app config reads a gitignored .env.local #4092.
• A warm Gradle daemon on the build worker runs React Native's node calls on the Node it started with #4081: not observed. Gradle started a fresh daemon, and the Android failure was a module-resolution error, not a Node version error.