Repository navigation
feat(desktop): loop every tutorial step illustration - #3417
Conversation
Finish and Delete loop with a hold on their end frame instead of playing once. Fixes #3411
|
Review: clear. Regenerating with |
|
Review: clear (after main merge). Reviewed head 3497186. The PR diff still contains only its four files, with no conflict markers. Regenerating with |
Description
The tutorial panel's Finish and Delete illustrations played once and then froze on their last frame (#3379, #3383). They were easy to miss: by the time you looked at the panel, the animation was over. The maintainer decided every step loops.
Solution
finish>deletestill starts from Finish's rest pose, the lidded jar.stim.modesany more, so the generator drops it andTutorialIllustrationalways plays the step's marker with.loop.Test plan
python3 website/scripts/build-stim-tutorial-lottie.pyregenerates both timelines byte for byte. A temporary lottie-ios render confirmed each loop's first and last frames match.stim macosfromapps/desktop, with the real~/.stimhome and the panel seeded at Finish and Archive. Captured with the patched agent-device (--surface app), only this app's window: the Finish illustration cycles lidded, app back, app fading, then lidded again, rendered by Core Animation.stim logs --errorswas empty, thenstim stopandagent-device daemon stop.swift test -Xswiftc -warnings-as-errorsandswift build -c release -Xswiftc -warnings-as-errorspass.Fixes #3411