ci: use poe tasks for model generation in CI workflow#705
Open
ci: use poe tasks for model generation in CI workflow#705
Conversation
vdusek
added
adhoc
vdusek
added
adhoc
vdusek
force-pushed
the
fix/regenerate-models-with-proper-names
branch
from
f88f46b to
505e56d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 94.64% 94.89% +0.24%
==========================================
Files 45 45
Lines 4405 4405
==========================================
+ Hits 4169 4180 +11
+ Misses 236 225 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
changed the title
Add `generate-models-from-file` poe task that accepts a local file path, working around datamodel-codegen's behavior where `url` in pyproject.toml takes precedence over the `--input` CLI flag. Update the CI workflow to call poe tasks instead of datamodel-codegen directly, ensuring the downloaded artifact is actually used when available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vdusek
force-pushed
the
fix/regenerate-models-with-proper-names
branch
from
f6571ca to
6def27d
Compare
Remove `url` from [tool.datamodel-codegen] config and pass it explicitly via --url/--input in poe tasks. This eliminates the sed workaround in generate-models-from-file and prevents --input from being silently ignored when url is set in config. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vdusek
force-pushed
the
fix/regenerate-models-with-proper-names
branch
from
6def27d to
746b9f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate-models-from-filepoe task that accepts a local file path, working arounddatamodel-codegenignoring--inputwhenurlis set inpyproject.tomldatamodel-codegendirectly, ensuring the downloaded artifact from apify-docs PRs is actually usedTest plan
poe generate-models-from-file <path>generates models without numbered classes (Error1, Type1, etc.)pyproject.tomlis restored after task execution🤖 Generated with Claude Code