fix(renovate): skip browser downloads during artifact update - #884
Draft
l2ysho wants to merge 1 commit into
Draft
Conversation
…update pnpm/npm's postinstall hook for puppeteer and playwright downloads a browser binary, which appears to fail in Renovate's own sandbox and breaks its lockfile regeneration step (renovate/artifacts). Every PR that bumps a package.json dependency then fails CI with ERR_PNPM_OUTDATED_LOCKFILE, even though pnpm install resolves fine locally. These env vars only apply to Renovate's own install command, not real CI, so tests still exercise real browsers. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
github-actions
Bot
added
the
t-tooling
l2ysho
added
adhoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ERR_PNPM_OUTDATED_LOCKFILE, because therenovate/artifactsstep never manages to write back an updatedpnpm-lock.yaml.pnpm install --no-frozen-lockfileresolves cleanly and produces a valid lockfile — the dependency graph is fine, so the problem is in Renovate's own environment, not the repo.puppeteer/playwrightpostinstall scripts download a full browser binary, which appears to fail (network-restricted sandbox) inside Renovate's own artifact-update run.PUPPETEER_SKIP_DOWNLOAD/PLAYWRIGHT_SKIP_BROWSER_DOWNLOADvia Renovate'senvconfig. This only affects the install command Renovate itself runs to compute the lockfile — real CI workflows are untouched and still download real browsers for tests. Verified the resulting lockfile is identical with or without the download.Test plan
renovate/artifactscheck on its next rebaseLint and test) then passespnpm install --frozen-lockfileon that PR