chore: use x-actor-request-id to charge - #138
Merged
Merged
Conversation
ruocco-l
marked this pull request as draft
August 17, 2026 10:15
ruocco-l
marked this pull request as ready for review
August 18, 2026 09:37
nikitachapovskii-dev
left a comment
nikitachapovskii-dev
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for explanation! Please fix lint alert Error: 10:45 error 'sendResponseIfFinished' is defined but never used @typescript-eslint/no-unused-vars
and the point below:
Comment on lines
292
to
300
| const response = await fetch(url, { | ||
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| Authorization: `Bearer ${token}`, | ||
| 'Idempotency-Key': randomId(), | ||
| }, | ||
| body: JSON.stringify({ eventName, count: 1, userAuthorization }), | ||
| body: JSON.stringify({ eventName, count: 1, requestId: actorRequestId }), | ||
| }); |
Collaborator
There was a problem hiding this comment.
As discussed in slack we would better add timeout here
nikitachapovskii-dev
self-requested a review
August 18, 2026 13:10
nikitachapovskii-dev
approved these changes
Aug 18, 2026
nikitachapovskii-dev
left a comment
nikitachapovskii-dev
left a comment
Collaborator
There was a problem hiding this comment.
No objections!
I think the fix for media can be done in a separate pr if we want to fix it 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just changing the header we use on charging to be up to specs and its related function/variable names.
We had to move around the
sendResponseIfFinishedbecause we want to charge before sending the request.