guard short handle string in XsbReader.readHandle#73
Open
aizu-m wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feeding the schema loader a crafted .xsb, it throws out of readHandle:
readHandle pulls a component handle off the .xsb string pool and switches on
handle.charAt(0) then handle.charAt(2) without checking the length first. An
empty handle trips charAt(0). A one or two char handle starting with '_' (say
"_X") trips charAt(2), and a three char one walks into QNameHelper.forPretty(handle, 4)
whose substring(4) throws too.
The loader is meant to surface a bad file as SchemaTypeLoaderException, the
reader only wraps IOException, and the method's own unresolved-handle branches
already throw BAD_HANDLE. So this index walk is the odd one out. Spotted it
fuzzing the reader with truncated handle strings.
Guarded the empty handle and the short '_' handle the same way. Valid handles
keep their existing path. Test in XsbReaderHandleTest.