Convert dom.serialization.Test to JUnit - #105
Open
elharo wants to merge 5 commits into
Open
Conversation
elharo
force-pushed
the
convert-serialization-to-junit
branch
from
July 7, 2026 22:04
d026376 to
d914084
Compare
elharo
force-pushed
the
convert-serialization-to-junit
branch
from
July 8, 2026 11:58
d914084 to
5c51def
Compare
elharo
force-pushed
the
convert-serialization-to-junit
branch
from
July 8, 2026 19:55
5c51def to
75da312
Compare
# Conflicts: # build.xml
mrglavas
reviewed
Jul 14, 2026
| } | ||
| public void testSerializationRoundTrip() throws Exception { | ||
| DocumentImpl doc = new DocumentImpl(); | ||
| Element root = doc.createElement("root"); |
There was a problem hiding this comment.
Should probably be using createElementNS() here to be consistent with namespace-aware API usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the dom.serialization.Test test harness from main()-driven to JUnit 3.