[REFACTOR][TIR] Use StructuralWalk in place of PostOrderVisit - #20308
Merged
Conversation
Replace PostOrderVisit call sites with typed StructuralWalk callbacks. The occurrence-insensitive consumers need no traversal-wide deduplication.
Replace the PostOrderVisit callback with a typed StructuralWalk callback while preserving tensor-level deduplication.
Replace visitor call sites with typed StructuralWalk callbacks while preserving monotone and set-valued consumers.
tqchen
force-pushed
the
refactor-tir-structural-walk
branch
from
September 10, 2026 12:39
72eab11 to
c50ff84
Compare
tlopex
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces TIR PostOrderVisit and PreOrderVisit usage with StructuralWalk.
A tree walk now uses a typed callback, and pre-order boolean descent becomes WalkResult::Advance or WalkResult::Skip. Sites retain identity sets only where a consumer depends on once-per-object behavior; buffer printer use counting instead uses def_region_kind to distinguish definitions from uses.
tirx::PostOrderVisit, tirx::PreOrderVisit, their helper visitors, FFI globals, and Python wrappers are removed. Python callers use tvm_ffi.structural_walk.