[Fix][Relax] Canonicalize strided slice begin indices - #20284
Merged
tlopex merged 1 commit intoSep 10, 2026
Conversation
napronald
marked this pull request as draft
September 7, 2026 07:30
napronald
force-pushed
the
fix-strided-slice-index-canonicalization
branch
from
September 7, 2026 08:41
cc499e6 to
6790484
Compare
napronald
marked this pull request as ready for review
September 7, 2026 10:22
tlopex
requested changes
Sep 8, 2026
tlopex
left a comment
tlopex
left a comment
Member
There was a problem hiding this comment.
Two different PrimVars can have the same name, so this can accidentally replace begin with extent and produce the wrong slice. Could you change the name check in DynamicCanonicalizeIndex to index.same_as(extent)?
napronald
force-pushed
the
fix-strided-slice-index-canonicalization
branch
from
September 8, 2026 07:18
6790484 to
26a9992
Compare
Contributor
Author
|
Updated to use |
napronald
force-pushed
the
fix-strided-slice-index-canonicalization
branch
from
September 10, 2026 03:23
26a9992 to
6597e06
Compare
tlopex
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #20262 and #20263.
Currently,
strided_slicelowering can fail whenbeginfalls outside the input bounds. The output shape already canonicalizesbeginandendwhenassume_inbound=False, but the generated source index could still use the originalbeginvalue. This can produces the correct output shape while reading from the wrong location or outside the input tensor.This PR updates the affected lowering paths to use the existing
CanonicalizeIndexlogic when constructing source indices and handlesbegin == extentwith a negative stride, where the canonical start isextent - 1. Existingassume_inbound=Truelogic is unchanged.