Skip to content

refactor(web): use singular requestFileHandle() instead of requestFileHandles() #19780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guan404ming merged 2 commits into from
Jun 16, 2026
+6 −8
Merged

refactor(web): use singular requestFileHandle() instead of requestFileHandles() #19780

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93e910b
refactor: use singular requestFileHandle() instead of requestFileHand…
tomayac Jun 15, 2026
b5d61d4
Merge branch 'apache:main' into refactor/cos-singular-requestFileHandle
tomayac Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions web/src/artifact_cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,10 @@ interface CrossOriginStorageWritable {
}

interface CrossOriginStorageAPI {
requestFileHandles(
descriptors: CrossOriginHashDescriptor[],
requestFileHandle(
descriptor: CrossOriginHashDescriptor,
options?: CrossOriginStorageRequestFileHandleOptions,
): Promise<CrossOriginStorageHandle[]>;
): Promise<CrossOriginStorageHandle>;
}

declare global {
Expand Down Expand Up @@ -169,8 +169,7 @@ class CrossOriginStorage {
if (!api) {
return undefined;
}
const handles = await api.requestFileHandles([hash]);
const handle = handles[0];
const handle = await api.requestFileHandle(hash);
if (!handle) {
return undefined;
}
Expand All @@ -189,10 +188,9 @@ class CrossOriginStorage {
if (!api) {
throw new Error("Cross-origin storage API unavailable.");
}
const handles = await api.requestFileHandles([hash], { create: true });
const handle = handles[0];
const handle = await api.requestFileHandle(hash, { create: true });
if (!handle) {
throw new Error("Cross-origin storage API returned no handles.");
throw new Error("Cross-origin storage API returned no handle.");
}
const writableStream = await handle.createWritable();
await writableStream.write(blob);
Expand Down
Loading