Skip to content

TIKA-4815: trivial follow-ups from the PR #3022 review - #3026

Merged
tballison merged 1 commit into
mainfrom
TIKA-4815-trivial-follow-ups
Aug 14, 2026
Merged

TIKA-4815: trivial follow-ups from the PR #3022 review#3026
tballison merged 1 commit into
mainfrom
TIKA-4815-trivial-follow-ups

Conversation

@tballison

Copy link
Copy Markdown
Contributor

What's in it:

  • PipesClientInterruptTest — setStartupTimeoutMillis(1000) bounds the non-interruptible handshake read that made the backoff test's flake window 60 s; both
    tests now try-with-resources the client; @timeout 30→45 (above the 35 s sum of awaits).
  • TikaGrpcConcurrencyTest — both burst tests now assert pipesParser.isSharedMode() matches the config, so a useSharedServer binding regression is catchable.
  • PerClientServerManager — log no longer says "mid-request" (it also fires mid-handshake) or claims an immediate recycle.
  • grpc index.adoc — Concurrency section ported from the README.

@tballison

Copy link
Copy Markdown
Contributor Author

@dpol1 wdyt?

@dpol1

dpol1 commented Aug 14, 2026

Copy link
Copy Markdown
Member

the isSharedMode pin is the right call - the burst alone can't prove the mode - and bounding the handshake read kills the one real flake window. LGTM

@tballison
tballison merged commit 433f576 into main Aug 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants