Repository navigation
THRIFT-6463: Remove the empty build leftovers in lib/ts/dist - #4062
Merged
Merged
Conversation
Client: ts lib/ts/dist/thrift.js is empty, and lib/ts/dist/thrift.min.js holds only a banner line. Nothing builds or reads lib/ts/dist, and the clean-local rule in lib/ts/Makefile.am deletes that directory, so every make clean left the two files deleted in the working tree. Remove them from the repository. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THRIFT-6463
clean-localinlib/ts/Makefile.amremoves thedistdirectory, and that directory held two tracked files:lib/ts/dist/thrift.js, which is empty, andlib/ts/dist/thrift.min.js, which holds a single banner line (/*! thrift 07-01-2019 */). Both came in with THRIFT-4675. After anymake cleaninlib/ts, or a top-level one with Java enabled,git statusshowed both files as deleted.Nothing builds or reads
lib/ts/dist: the TypeScript tests copylib/js/src/thrift.jsintotest/build, anddist-hookalready leavesdist/out of the source tarball. This change removes the two files.Makefile.amis unchanged.Checked in
thrift:jammy, configured with the CI's library arguments (Java on), by runningmake -C lib/ts cleanand thengit status --short:git status --shortD lib/ts/dist/thrift.jsD lib/ts/dist/thrift.min.jsNot touched here:
lib/ts/Gruntfile.jsstill has aconcatconfig fordist/thrift.jsand a header comment about buildingdist/.grunt-contrib-concatis not loaded in that Gruntfile, so neither has an effect.🤖 Generated with Claude Code