Skip to content

THRIFT-6435: Wait until the browser-test servers listen instead of sleeping #4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jens-G wants to merge 1 commit into
base: master
Choose a base branch
from
+62 −8
Open

THRIFT-6435: Wait until the browser-test servers listen instead of sleeping #4025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions lib/js/Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,12 +307,39 @@ module.exports = function (grunt) {

grunt.registerTask(
"wait",
"Wait just one second for the server to start",
"Wait until the test servers accept connections",
function () {
var done = this.async();
setTimeout(function () {
done(true);
}, 1000);
var net = require("net");
var ports = [8088, 8089, 8090, 8091];
var deadline = Date.now() + 30000;
var probe = function (index) {
if (index === ports.length) {
done(true);
return;
}
var socket = net.connect(ports[index], "localhost");
socket.on("connect", function () {
socket.destroy();
probe(index + 1);
});
socket.on("error", function () {
socket.destroy();
if (Date.now() < deadline) {
setTimeout(function () {
probe(index);
}, 100);
} else {
grunt.log.error(
"Nothing is listening on port " +
ports[index] +
" after 30 seconds",
);
done(false);
}
});
};
probe(0);
},
);

Expand Down
35 changes: 31 additions & 4 deletions lib/ts/Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,39 @@ module.exports = function (grunt) {

grunt.registerTask(
"wait",
"Wait just one second for the server to start",
"Wait until the test server accepts connections",
function () {
var done = this.async();
setTimeout(function () {
done(true);
}, 1000);
var net = require("net");
var ports = [8089];
var deadline = Date.now() + 30000;
var probe = function (index) {
if (index === ports.length) {
done(true);
return;
}
var socket = net.connect(ports[index], "localhost");
socket.on("connect", function () {
socket.destroy();
probe(index + 1);
});
socket.on("error", function () {
socket.destroy();
if (Date.now() < deadline) {
setTimeout(function () {
probe(index);
}, 100);
} else {
grunt.log.error(
"Nothing is listening on port " +
ports[index] +
" after 30 seconds",
);
done(false);
}
});
};
probe(0);
},
);

Expand Down
Loading