Repository navigation
THRIFT-6401: Declare the minimum Visual C++ runtime for WinGet and Chocolatey, and drop the dead Chocolatey icon - #3997
Merged
Conversation
…ocolatey, and drop the dead Chocolatey icon Client: build The Chocolatey review of the thrift 0.25.0 package flagged the nuspec's iconUrl, which returns 404, and a dependency without a version. There is no square Thrift logo to point at, so the package goes without an icon, as the 0.12.0 package did. The released thrift.exe links the shared Visual C++ runtime, and the installed redistributable has to be at least as new as the build tools the program was built with; thrift-0.25.0.exe reports linker version 14.51. Without a minimum, any vcredist140 that is already installed satisfies the dependency and is not updated, and the WinGet manifest had the same gap. The nuspec now asks for vcredist140 14.51 or later, and the WinGet installer manifest asks for Microsoft.VCRedist.2015+.x64 14.51 or later through MinimumVersion, quoted so that YAML keeps it a string. The tests check both minimums, that the two agree, and that the nuspec names no icon. doc/ReleaseManagement.md says to raise the minimum when the compiler is built with newer build tools, and build/windows/README.md mentions it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mergeable
Bot
added
the
build and general CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THRIFT-6401
The Chocolatey review of the
thrift0.25.0 package, which is still in moderation, flagged two things inthrift.nuspec.in:iconUrl,https://thrift.apache.org/assets/images/thrift-logo.svg, returns 404. There is no square Thrift logo to point at: the site's favicon is the ASF leaf, and the ASF logo service only has the wordmark. So the package goes without an icon, as the 0.12.0 package did.vcredist140dependency names no version. Microsoft's binary compatibility rules say that the installed redistributable "must be at least as new as the latest build tools used by any app component", andthrift-0.25.0.exereports linker version 14.51. Without a minimum, anyvcredist140that is already installed satisfies the dependency and is not updated.The WinGet manifest declares
Microsoft.VCRedist.2015+.x64without a minimum as well.Changes
thrift.nuspec.in: noiconUrl, and<dependency id="vcredist140" version="14.51" />.Apache.Thrift.installer.yaml.in:MinimumVersion: '14.51'under the redistributable. The value is quoted, so that YAML does not read it as a number and the schema does not reject it.test-chocolatey-package.ps1checks that the dependency names a minimum, that it matches the WinGet template, and that the nuspec names no icon.test-winget-manifests.ps1checks that the rendered manifest carries the quoted minimum.doc/ReleaseManagement.md, in the compiler build steps: raise both values when the compiler is built with newer build tools.dumpbin /headersshows their version.build/windows/README.mdmentions the minimum.Both package managers offer 14.51.36247 of the redistributable, so the minimum can be met.
Verification
validate_manifests.pyagainst the WinGet 1.12.0 schemas. The staged nuspec is well-formed and carries the versioned dependency and no icon.choco packitself runs in this PR's Chocolatey job.thrift-0.25.0.exe(9e1cb466…):objdump -pgives MajorLinkerVersion 14 and MinorLinkerVersion 51.After this is merged, the Chocolatey workflow pushes 0.25.0 again with the same version, which Chocolatey allows while the version is in moderation. The open WinGet submission for 0.25.0 is left as it is.
🤖 Generated with Claude Code