Repository navigation
THRIFT-6396: Let a manual run of the WinGet and Chocolatey workflows publish - #3983
Merged
Merged
Conversation
…publish Client: build When a release run is too early for archive.apache.org, the documented way to publish is to run the workflow again from the Actions tab. That run could not publish anything: only a release event downloaded the published installer, so a manual run used the placeholder checksum, and the submit and push jobs only ran for a release. Now only a pull request uses the placeholder, and a manual run submits or pushes like a release. doc/ReleaseManagement.md: - describes how to add the installer to dist/release after the release, when it was not part of the release candidate, built from the voted compiler; - says that a release run can be re-run for 30 days, and that a manual WinGet run needs the release date; - no longer describes the Chocolatey id takeover as pending; - says that the secrets and the variable can be set for the repository or for the release environment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mergeable
Bot
added
the
github_actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THRIFT-6396
When a WinGet or Chocolatey release run is too early for
archive.apache.org,doc/ReleaseManagement.mdsays to run the workflow again from the Actions tab. Such a manual run could not publish anything:releaseevent downloaded the published installer, so a manual run rendered the manifests and packed the package with theDEADBEEF…placeholder checksum;releaseevent, so a manual run skipped them and still finished green.Now only a pull request uses the placeholder. A manual run downloads the published installer and submits or pushes like a release run. Pull requests and pre-releases behave as before.
doc/ReleaseManagement.md:dist/releaseafter the release, when it was not part of the release candidate, as for 0.25.0. It has to be built from the voted compiler; thewindows-installerartifact ofWindows packagescontains a compiler that the workflow built itself;thriftid as pending; the workflow's comments and run summary are updated to match;releaseenvironment.Verification
A script evaluates the job conditions and the environment of the render/build step from the workflow file for each kind of event, then runs the step's PowerShell with
VERSION=0.25.0:pull_requestworkflow_dispatcharchive.apache.org/dist/thrift/0.25.0/thrift-0.25.0-setup.exe; submit/push runsreleaserelease, pre-releaseThe download itself returns 404 today, because the 0.25.0 installer is not on the archive yet; for this check it only matters that it is attempted. actionlint and zizmor (
--persona regular, with a token) report nothing.🤖 Generated with Claude Code