[slachiewicz]

Adds TConfiguration.cpp with out-of-line definitions of DEFAULT_MAX_MESSAGE_SIZE, DEFAULT_MAX_FRAME_SIZE and DEFAULT_RECURSION_DEPTH, so binding one to a reference links before C++17. The new test takes each constant's address through a volatile pointer, which needs the definitions at any optimisation level; on master it fails to link even in a Release build.

Verified: Ubuntu 24.04 arm64, GCC 13, C++11 — Debug build of UnitTests links and passes 141/141 (fails to link on master); TTransportFactoryConfigTest 11/11 in Debug and Release.

[Jens-G]

Code review

No blocking issues found. Checked for bugs and CLAUDE.md compliance.

One suggestion, below the bar for an issue but verified:

• The comment says binding one of these constants to a reference "needs a definition before C++17". The header declares them const static int, and C++17 made only constexpr static data members implicitly inline, so an odr-use needs these definitions in every standard for as long as the header keeps that declaration. The commit message states the right condition ("drop it only once the constants become inline constexpr"), and the comment could say the same.

thrift/lib/cpp/src/thrift/TConfiguration.cpp

Lines 24 to 29 in e20168f

	// Binding one of these constants to a reference, as std::make_shared or
	// std::min do, needs a definition before C++17.
	const int TConfiguration::DEFAULT_MAX_MESSAGE_SIZE;
	const int TConfiguration::DEFAULT_MAX_FRAME_SIZE;
	const int TConfiguration::DEFAULT_RECURSION_DEPTH;

🤖 Generated with Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[slachiewicz]

The comment and the commit message now say the definition is needed in every standard for as long as the constants are static const.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.