fix(amber, v1.2): guard resends by destination - #8062
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
### What changes were proposed in this PR? Use the destination worker, rather than the sender, when deciding whether an unacknowledged network message can be resent. ```text Before: timeout -> sender exists -> resend toward a removed destination After: timeout -> destination exists -> resend; otherwise keep the message pending ``` Regression tests cover both directions: a registered destination with an unknown sender resends successfully, while a registered sender with a missing destination does not resend. ### Any related issues, documentation, discussions? Closes #6921. ### How was this PR tested? The two regression tests were added first and both failed against the old sender guard. After the one-line fix: ```text sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.common.PekkoMessageTransferServiceSpec" ``` Result: 5 tests passed. ```text sbt "scalafixAll --check" "scalafmtCheckAll" git diff --check ``` Result: all lint, formatting, and diff checks passed. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Codex was used for implementation and verification assistance. I reviewed the final code and test output before submission. (backported from commit e54ecd2)
Contributor
Author
|
The cherry-pick conflicted and was committed with conflict markers. Resolve the conflicts on this branch, then mark this PR ready for review. Conflicting files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Automated backport of #8002 to
release/v1.2.Source: e54ecd2 · automation run
Any related issues, documentation, discussions?
Backport of #8002. Originally linked #6921.
How was this PR tested?
Release-branch CI runs on this branch once the conflicts are resolved and this PR is marked ready for review.
Was this PR authored or co-authored using generative AI tooling?
No.