Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions common/config/src/main/resources/gui.conf
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ gui {
timetravel-enabled = false
timetravel-enabled = ${?GUI_WORKFLOW_WORKSPACE_TIMETRAVEL_ENABLED}

# whether the Form View (a second, form-based view of a workflow) is enabled
form-view-enabled = false
form-view-enabled = ${?GUI_WORKFLOW_WORKSPACE_FORM_VIEW_ENABLED}

# Whether to connect to local or production shared editing server. Set to true if you have
# reverse proxy set up for y-websocket.
production-shared-editing-server = false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ object GuiConfig {
conf.getBoolean("gui.workflow-workspace.async-rendering-enabled")
val guiWorkflowWorkspaceTimetravelEnabled: Boolean =
conf.getBoolean("gui.workflow-workspace.timetravel-enabled")
val guiWorkflowWorkspaceFormViewEnabled: Boolean =
conf.getBoolean("gui.workflow-workspace.form-view-enabled")
val guiWorkflowWorkspaceProductionSharedEditingServer: Boolean =
conf.getBoolean("gui.workflow-workspace.production-shared-editing-server")
val guiWorkflowWorkspacePythonLanguageServerPort: String =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ class GuiConfigSpec extends AnyFlatSpec with Matchers {
ifUnset("GUI_WORKFLOW_WORKSPACE_TIMETRAVEL_ENABLED")(
GuiConfig.guiWorkflowWorkspaceTimetravelEnabled shouldBe false
)
// Form View ships disabled so merging the feature never turns it on; the final PR flips it.
ifUnset("GUI_WORKFLOW_WORKSPACE_FORM_VIEW_ENABLED")(
GuiConfig.guiWorkflowWorkspaceFormViewEnabled shouldBe false
)
ifUnset("GUI_WORKFLOW_WORKSPACE_PRODUCTION_SHARED_EDITING_SERVER")(
GuiConfig.guiWorkflowWorkspaceProductionSharedEditingServer shouldBe false
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ class ConfigResource {
"linkBreakpointEnabled" -> GuiConfig.guiWorkflowWorkspaceLinkBreakpointEnabled,
"asyncRenderingEnabled" -> GuiConfig.guiWorkflowWorkspaceAsyncRenderingEnabled,
"timetravelEnabled" -> GuiConfig.guiWorkflowWorkspaceTimetravelEnabled,
"formViewEnabled" -> GuiConfig.guiWorkflowWorkspaceFormViewEnabled,
"productionSharedEditingServer" -> GuiConfig.guiWorkflowWorkspaceProductionSharedEditingServer,
"defaultExecutionMode" -> GuiConfig.guiWorkflowWorkspaceDefaultExecutionMode,
"workflowEmailNotificationEnabled" -> GuiConfig.guiWorkflowWorkspaceWorkflowEmailNotificationEnabled,
Expand Down
1 change: 1 addition & 0 deletions frontend/src/app/common/service/gui-config.service.mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export class MockGuiConfigService {
linkBreakpointEnabled: false,
asyncRenderingEnabled: false,
timetravelEnabled: false,
formViewEnabled: false,
productionSharedEditingServer: false,
pythonLanguageServerPort: "3000",
defaultDataTransferBatchSize: 100,
Expand Down
1 change: 1 addition & 0 deletions frontend/src/app/common/type/gui-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export interface GuiConfig {
linkBreakpointEnabled: boolean;
asyncRenderingEnabled: boolean;
timetravelEnabled: boolean;
formViewEnabled: boolean;
productionSharedEditingServer: boolean;
pythonLanguageServerPort: string;
defaultDataTransferBatchSize: number;
Expand Down
Loading