fix(frontend): disable repeat remove buttons - #7995
Draft
anthonychengit wants to merge 1 commit into
Draft
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
Backport auto-label reportThis
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7995 +/- ##
=========================================
Coverage 93.21% 93.21%
Complexity 4664 4664
=========================================
Files 1175 1175
Lines 47646 47646
Branches 5319 5319
=========================================
+ Hits 44413 44414 +1
Misses 1752 1752
+ Partials 1481 1480 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aglinxinyuan
approved these changes
Aug 27, 2026
Contributor
|
Please add a before-and-after screenshot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Rename the repeat row's
*ngForvariable so it no longer shadows the component'sfield. The remove buttons now read the section-leveltemplateOptions.disabled, matching the add button.Permanent rendering tests cover both directions: every remove button is disabled for a disabled section, and every remove button remains available otherwise.
Any related issues, documentation, discussions?
Closes #7431
How was this PR tested?
Result: 14 tests passed; the frontend Prettier and ESLint CI check passed;
git diff --checkpassed.The before/after evidence was captured from the actual Angular component in Playwright Chromium with
templateOptions.disabled = true.Was this PR authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)