Skip to content

[SYSTEMDS-3979] Split MM Chain into separate Statement Block - #2623

Open
ywcb00 wants to merge 5 commits into
apache:mainfrom
ywcb00:feat/recompile/sparsity/mmchain
Open

ywcb00 wants to merge 5 commits into
apache:mainfrom
ywcb00:feat/recompile/sparsity/mmchain

Conversation

@ywcb00

@ywcb00 ywcb00 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Hello there,
this PR splits the inputs of a matrix multiplication chain into their own statement block to ensure the MM chain receives correct sparsity information as input (i.e., the sparsity is computed before sparsity rewrites).
The tests are modified accordingly.
All the best,
David

…va class to not being exclusive for read instructions
…multiplication chain into their own statement block
…parate method for processing the children of matrix multiplication hops

chore(test/functions/rewrite/RewriteSplitDagUnkownNnzReadTest.java): update assert string check to the new version of the log output
… into separate statement block only before the chain instead of before and after the chain
@github-project-automation github-project-automation Bot moved this to In Progress in SystemDS PR Queue Oct 13, 2026
@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.05556% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.15%. Comparing base (fc1bf7a) to head (4e2b6ae).

Files with missing lines Patch % Lines
.../sysds/hops/rewrite/RewriteSplitDagUnknownNnz.java 92.95% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2623       +/-   ##
=============================================
- Coverage     76.68%   72.15%    -4.54%     
- Complexity        0    51090    +51090     
=============================================
  Files           452     2096     +1644     
  Lines         28066   226485   +198419     
  Branches          0    38581    +38581     
=============================================
+ Hits          21523   163416   +141893     
- Misses         6543    51913    +45370     
- Partials          0    11156    +11156     
Flag Coverage Δ
java 71.51% <93.05%> (?)
python 76.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant