Skip to content

[OOC] Wire OOC Aggregate Unary and Bugfix Race Condition - #2592

Merged
janniklinde merged 1 commit into
apache:mainfrom
janniklinde:ooc/agg-unary
Aug 18, 2026
Merged

janniklinde merged 1 commit into
apache:mainfrom
janniklinde:ooc/agg-unary

Conversation

@janniklinde

Copy link
Copy Markdown
Contributor

This PR extends GroupedReduce primitive to different grouping formats. Further, this patch wires AggregateUnaryOOCInstruction to use those new primitives. This patch also provides a race condition fix for OOCCacheImpl.

Assisted-by: AI

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.89474% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.43%. Comparing base (9dccbc3) to head (5668ac5).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...instructions/ooc/AggregateUnaryOOCInstruction.java 42.02% 38 Missing and 2 partials ⚠️
...time/ooc/primitives/GroupedReduceOOCPrimitive.java 71.66% 11 Missing and 6 partials ⚠️
...g/apache/sysds/runtime/ooc/cache/OOCCacheImpl.java 63.15% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2592      +/-   ##
============================================
- Coverage     71.44%   71.43%   -0.02%     
- Complexity    50437    50448      +11     
============================================
  Files          1629     1629              
  Lines        195513   195586      +73     
  Branches      38118    38129      +11     
============================================
+ Hits         139686   139708      +22     
- Misses        44867    44909      +42     
- Partials      10960    10969       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janniklinde
janniklinde merged commit 1cc9c09 into apache:main Aug 18, 2026
51 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in SystemDS PR Queue Aug 18, 2026
@janniklinde
janniklinde deleted the ooc/agg-unary branch October 1, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant