Repository navigation
[SYSTEMDS-3924] Primitive for Implicit OOC Stream Creation/Reset - #2340
Closed
janniklinde wants to merge 3 commits into
Closed
janniklinde wants to merge 3 commits into
janniklinde wants to merge 3 commits into
Conversation
Contributor
|
LGTM - thanks for the additional tests @janniklinde and checking this primitive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch provides additional tests to validate OOC collect on
acquireRead(). So far, no issues have been observed with stream collection beyond those caused by limitations of the underlying instructions (e.g., unsupported scalar-matrix OOC binary OPs, or TSMMOOCInstruction supporting at most 1000x1000 output matrix sizes).Additionally, it includes a minor fix for the out-of-core TransposeTest (for correctly reading output matrices from HDFS).