Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2323 +/- ##
=========================================
Coverage 72.26% 72.27%
- Complexity 46646 46651 +5
=========================================
Files 1496 1497 +1
Lines 176874 176903 +29
Branches 34771 34771
=========================================
+ Hits 127820 127853 +33
+ Misses 39405 39402 -3
+ Partials 9649 9648 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Hi @mboehm7 , I've implemented TSMM. Thanks to your note on column <= blocksize, It is a bit straightforward implementation. could you please check once. thanks |
Contributor
|
LGTM - thanks for the patch @j143. Overall, this was a good start. During the merge I made the following additional modifications:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TSMM operation using existing
transposeSelfMatrixMultOperationsassuming the the number columns <= size of block.This scenario: a matrix with many rows but few columns <= blocksize (1000) .
Let's walk through an example of a 6x2 matrix
Xwith a block size of 2x2. This matrix is "tall" (it has 3 blocks of rows) and "skinny" (it has only 1 block of columns).The operation is$C = t(X) \cdot X$ . The output
Cwill be a small 2x2 matrix.The Input Matrix
XFirst, let's visualize our input matrix. It's a single stream of three blocks:
X1,X2, andX3.The algorithm will compute the final result
Cby summing thetsmmof each individual block:The Streaming Process
We this stream one block at a time, adding each result to a single accumulator block (
resultBlock) that stays in memory.1. Initialization
An empty 2x2
resultBlockis created. This is our accumulator.2. Processing the Stream
The
whileloop begins, processing one block at a time.Iteration 1: Process
X1resultBlock.Iteration 2: Process
X2resultBlock.Iteration 3: Process
X3resultBlock.Final Result
Once the stream is empty, the loop terminates, and the final
resultBlockis sent to the output. This entire process read the massive 6x2 input matrix while only holding one small input block and the small 2x2 result block in memory at any given time.