Skip to content

fix(i18n): backfill missing German translations - #45886

Merged
sfirke merged 4 commits into
apache:masterfrom
proBieri:fix/i18n-de-backfill
Oct 30, 2026
Merged

sfirke merged 4 commits into
apache:masterfrom
proBieri:fix/i18n-de-backfill

Conversation

@proBieri

Copy link
Copy Markdown
Contributor

SUMMARY

Brings the German (de) catalog to full coverage.

  • Fills the 1043 entries that had no German translation.
  • Reviews every one of the 1084 previously fuzzy entries (the new ones plus existing fuzzy ones) by hand, one by one. 1083 were accepted as is and one was corrected. All fuzzy flags are removed.
  • Translations follow the terminology already in the catalog (Datensatz, Diagramm, Design for theme, Alarm, Schlagwort, Zeitraster, semantische Schicht, Anmerkungsebene, …).
  • Fixes the singular form of "Reused by %s other submissions" so that it uses the %s placeholder like the plural form does.

Result: 5893 translated messages, 0 fuzzy, 0 untranslated.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Not applicable (translation strings only).

TESTING INSTRUCTIONS

  1. msgfmt --statistics -o /dev/null superset/translations/de/LC_MESSAGES/messages.po reports 5893 translated messages, with no fuzzy or untranslated ones.
  2. Set the UI language to German and check the newer areas, for example semantic views, version history, alerts & reports retries, and the password reset flow.

Note: msgfmt --check reports one false positive on "% of" → "% von". The .pot file marks this msgid as python-format because % o looks like a format directive. The string is a plain frontend label (FormattingPopoverContent.tsx), so the translation is correct.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

proBieri and others added 2 commits October 29, 2026 17:41
Fill all 1043 untranslated entries in the German catalog using
scripts/translations/backfill_po.py. Every new entry is marked
`#, fuzzy` with a machine-translation comment so reviewers can
confirm it before the flag is removed.

After the backfill, align terminology with the existing catalog:
Datensatz (dataset), Diagramm (chart), Design (theme), Alarm (alert),
Schlagwort (tag), Zeitraster (time grain), semantische Schicht
(semantic layer), Anmerkungsebene (annotation layer) and the
gender-inclusive Bearbeiter*in (editor). Also correct a few
mistranslations, e.g. "Zebra striping" and "Center value".

Existing confirmed translations are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop the fuzzy flag and machine-translation comments from the 1084
German entries after a full manual review, and apply the one reviewer
correction ("Database upload file exceeds the maximum allowed size.").
Use %s in the singular plural form of "Reused by %s other submissions"
so the placeholder counts match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the i18n Namespace | Anything related to localization label Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.71%. Comparing base (e239df1) to head (92d7d88).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #45886      +/-   ##
==========================================
- Coverage   84.72%   84.71%   -0.02%     
==========================================
  Files        3069     3069              
  Lines      205678   205661      -17     
  Branches    48350    48336      -14     
==========================================
- Hits       174267   174221      -46     
- Misses      28119    28148      +29     
  Partials     3292     3292              
Flag Coverage Δ
hive 34.51% <ø> (ø)
mysql 52.58% <ø> (+<0.01%) ⬆️
postgres 52.59% <ø> (ø)
presto 36.24% <ø> (ø)
python 87.75% <ø> (ø)
sqlite 52.35% <ø> (ø)
unit 82.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@proBieri
proBieri marked this pull request as ready for review October 30, 2026 11:13
@codeant-ai-for-open-source

Copy link
Copy Markdown
Contributor

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 92d7d88960f0

@sfirke
sfirke merged commit 01a1520 into apache:master Oct 30, 2026
118 checks passed
@sfirke

sfirke commented Oct 30, 2026

Copy link
Copy Markdown
Member

thanks @proBieri !

@proBieri
proBieri deleted the fix/i18n-de-backfill branch October 30, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Namespace | Anything related to localization size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants