[Vitor-Avila]

SUMMARY

When you create a dataset from Datasets → + Dataset and click Create dataset and create chart, the Create Chart page is supposed to preselect the dataset you just created. The add-dataset footer already receives the new dataset's ID from the create call, but it threw the ID away and redirected to /chart/add/?dataset=<table_name>. The Create Chart page then resolved that name with a table_name lookup limited to one result and ordered only by table_name.

Dataset names are only unique per database, catalog and schema. When another dataset with the same table name exists in a different schema, catalog or database, the lookup returns whichever row the database happens to put first. That is often the older dataset, so the user can unknowingly build a chart on the wrong data.

This change:

• redirects with the created dataset's ID (/chart/add/?dataset_id=<id>);
• makes the Create Chart page preselect only from dataset_id, fetching it directly with GET /api/v1/dataset/<id> and a column selection (the same fields the dataset picker already uses). A missing or inaccessible ID leaves the picker empty;
• removes name-based preselection (?dataset=<name>), which was never reliable for the reason above. UPDATING.md documents the change;
• moves the "The dataset has been saved" toast into the add-dataset footer, right after the create succeeds. The Create Chart page no longer shows it, so a hand-built /chart/add?dataset_id=<id> link doesn't announce a save that didn't happen;
• removes the exactMatch / datasetsOnly options of fetchDatasourceList, which existed only for the name lookup.

SQL Lab's "Save dataset → Save & Explore" and saving a chart from a SQL Lab query already redirect by ID and are not affected.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Several datasets named foo exist in different schemas of the same database.

Before

Before this change, the page could preselect a pre-existing foo (here schema_a) instead of the one just created.

After

After running Create dataset and create chart for a new foo in schema_f, that dataset is preselected and the saved toast is shown.

TESTING INSTRUCTIONS

1. Create a dataset from a table named foo in one schema (for example schema_a).
2. Go to Datasets → + Dataset, pick a table also named foo in another schema or database, and click Create dataset and create chart.
3. Check that the "The dataset has been saved" toast appears and that the preselected dataset is the one just created (hover to see its database/schema).
4. Open /chart/add/?dataset_id=<id> by hand: that dataset is preselected and no toast appears. /chart/add/?dataset_id=<unknown id> leaves the picker empty. /chart/add/?dataset=foo no longer preselects anything.

Automated:

• ChartCreation.test.tsx: dataset_id is fetched via GET /api/v1/dataset/<id> with the column selection and preselected (with and without semantic layers); 404 and 500 responses leave the picker empty and stop the loading state; a ?dataset= param triggers no request; the page shows no toast.
• Footer.test.tsx: after a successful create returning 42, the redirect is /chart/add/?dataset_id=42 and the saved toast fires.
• fetchDatasourceList.test.ts: fetchDatasetById request shape.
• npx jest src/pages/ChartCreation src/features/datasets src/views: 183/183 pass.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API (the ?dataset=<name> parameter of /chart/add; see UPDATING.md)

🤖 Generated with Claude Code

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	1c69933
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6ae39eff8d72e7c0301255fb
😎 Deploy Preview	https://deploy-preview-45854--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.70%. Comparing base (a8c13c6) to head (5d8731d).

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #45854       +/-   ##
===========================================
+ Coverage   65.62%   84.70%   +19.08%     
===========================================
  Files        3069     3069               
  Lines      205661   205597       -64     
  Branches    48336    48322       -14     
===========================================
+ Hits       134956   174160    +39204     
+ Misses      67624    28145    -39479     
- Partials     3081     3292      +211     

Flag	Coverage Δ
javascript	80.95% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open issues

• If the URL contains an empty dataset id (e.g. ?dataset_id=), has('dataset_id') can still make… · New
• This builds a URL path segment directly from a user-controlled value (via dataset_id in the… · New
• The variable name hasDatasetParam is now misleading since it specifically checks dataset_id.… · New

What changed in this PR

Updates chart creation flow to reliably preselect the newly created dataset by using its numeric ID instead of a non-unique name lookup, and relocates the “dataset saved” toast to the dataset creation flow.

Changes:

• Redirect from dataset creation to /chart/add/?dataset_id=<id> and remove name-based preselection (?dataset=<name>).
• Preload the dataset on Chart Creation via GET /api/v1/dataset/<id> (with column selection) and handle missing/inaccessible IDs by leaving the picker empty.
• Remove exactMatch / datasetsOnly options from fetchDatasourceList and document the breaking URL param change in UPDATING.md.

File	Description
superset-frontend/​src/​pages/​ChartCreation/​index.tsx	Switches preselection logic from name-based lookup to dataset ID fetch; removes toast from page load.
superset-frontend/​src/​pages/​ChartCreation/​ChartCreation.test.tsx	Updates/extends tests to cover dataset_id preselection, error cases, and no-toast behavior.
superset-frontend/​src/​features/​datasets/​fetchDatasourceList.ts	Simplifies datasource list fetch options and adds fetchDatasetById.
superset-frontend/​src/​features/​datasets/​fetchDatasourceList.test.ts	Adds coverage for the new fetchDatasetById request shape and error behavior.
superset-frontend/​src/​features/​datasets/​AddDataset/​Footer/​index.tsx	Redirects by newly created dataset ID and shows the “saved” toast on successful create.
superset-frontend/​src/​features/​datasets/​AddDataset/​Footer/​Footer.test.tsx	Verifies redirect by ID and toast emission prior to navigation.
UPDATING.md	Documents removal of ?dataset=<name> preselection support.

_{Review effort: Lite}

[codeant-ai-for-open-source]

  CodeAnt PR Risk

🟢  Low Risk

• The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 5d8731dcfa0a