[mikebridge]

TL;DR: when deleting a semantic layer or view is refused because other assets depend on it, the dialog now names those assets, including archived ones, so you can find and fix them. You only see names you could already see elsewhere; anything else is shown as a count with a hint to ask an admin.

SUMMARY

The delete refusal (409) already returned up to 20 dependents, but the dialogs showed counts only. Archived dependents were never named, even to admins, because visibility was computed over live rows only.

• Archived blockers are named to the people who could restore them. Archived charts and dashboards are named to the users Recently Archived would show them to: admins see every archived item, and others see the items they edit. The live visibility filters are unchanged. Each dependent carries an archived flag, and the rest are counted in inaccessible_count as before.
• The dialogs list the dependents. The layer and view delete dialogs show:
  • the dependents' names and types, with "archived" where it applies;
  • links to live charts and dashboards;
  • "and N more" past the 20 listed;
  • a note to ask an admin when some dependents are hidden.
• Copy:
  • the refusal no longer says "Semantic source";
  • the view dialog gets the trash icon and the bold name the layer dialog has;
  • "Recently Archived" capitalisation is consistent in the database dialog;
  • an empty layer reads "has no semantic views".

The deletion policy itself is unchanged.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: "Deletion is blocked by 15 dependent assets (2 archived)", with no names. After: the same line plus a list of the blocking charts and dashboards, archived ones marked, live ones linked.

TESTING INSTRUCTIONS

• pytest tests/unit_tests/commands/semantic_layer/delete_test.py tests/unit_tests/semantic_layers/api_test.py
• npm run test -- src/pages/DatasetList src/pages/DatabaseList
• Manually, with SEMANTIC_LAYERS and SOFT_DELETE on:
  1. Create a chart on a semantic view, archive it, and try to delete the view as an admin. The dialog names the archived chart.
  2. As a non-admin who doesn't edit that chart, the chart is counted, with the ask-an-admin note.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags: SEMANTIC_LAYERS (and SOFT_DELETE for archived assets)
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

The 409 gains one additive field per dependent (archived); existing fields keep their meaning.

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	a3cd6b9
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6ae294a19347388e1ec5fc05
😎 Deploy Preview	https://deploy-preview-45642--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.71%. Comparing base (a8c13c6) to head (03cda6a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #45642       +/-   ##
===========================================
+ Coverage   65.62%   84.71%   +19.09%     
===========================================
  Files        3069     3070        +1     
  Lines      205661   205699       +38     
  Branches    48336    48349       +13     
===========================================
+ Hits       134956   174268    +39312     
+ Misses      67624    28139    -39485     
- Partials     3081     3292      +211     

Flag	Coverage Δ
hive	34.51% <26.66%> (-0.01%)	⬇️
javascript	80.96% <100.00%> (+0.01%)	⬆️
mysql	52.58% <26.66%> (-0.01%)	⬇️
postgres	52.58% <26.66%> (-0.01%)	⬇️
presto	36.24% <26.66%> (-0.01%)	⬇️
python	87.76% <100.00%> (+34.89%)	⬆️
sqlite	52.35% <26.66%> (-0.01%)	⬇️
unit	82.49% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[codeant-ai-for-open-source]

  CodeAnt PR Risk

🟢  Low Risk

• The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 03cda6a70623

[aminghadersohi]

LGTM. Archived charts and dashboards now block the delete, are named only to users who can restore them, and the counts and API schema are consistent. CI green.