[rusackas]

SUMMARY

Refreshes the Home page's Recent Activity section automatically after a dashboard or chart is deleted, instead of requiring a manual page reload. This is a rebase + fix-up of @guptapuja's work in #39528, opened fresh because the token used here lacks the workflow scope needed to push directly to their fork.

Closes #39528 - thanks for the work here @guptapuja!

On top of the rebase, this adds one small fix and some test coverage that review rounds on the original PR had asked for:

• ChartTable's delete flow calls getData(chartFilter) instead of refreshData whenever the active tab isn't "Mine" - that path was passing the raw, unwrapped getData through, so deleting a chart from the default/Other tab never fired the new onActivityRefresh callback at all. Wrapped it the same way DashboardTable already wraps its own getData (handleGetData).
• Added test coverage for the onActivityRefresh wiring in both ChartTable.test.tsx and DashboardTable.test.tsx, which is what caught the gap above.

A later round added a Playwright E2E suite (playwright/tests/home/recent-activity-refresh.spec.ts) covering all six combinations of {Favorite, Mine, All} x {Dashboards, Charts}: create a throwaway asset, view it to seed a real Recents entry, delete it from that tab, and assert the Recents entry disappears promptly. See the PR comment below for how that came about.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

pr45589-demo-v2.mp4

(A cleaner recording is in progress - see the comment below.)

TESTING INSTRUCTIONS

1. Go to the Home page.
2. Delete a dashboard or chart from the Dashboards/Charts section (try the "Favorite", "Mine", and "All" tabs).
3. Observe the Recent Activity / Recents section updates automatically, without a page reload, in every case.

Or run the new E2E suite: npx playwright test playwright/tests/home/recent-activity-refresh.spec.ts.

ADDITIONAL INFORMATION

• Has associated issue: Closes fix(home): refresh recent activity after dashboard/chart delete #39528 (and the underlying Delete Dashboard & Chart in Home page doesn't refresh/reload Recent activity #39435)
• Required feature flags:
• Changes UI
• Includes DB Migration
• Introduces new feature or API
• Removes existing feature or API

🤖 Generated with Claude Code

[codeant-ai-for-open-source]

  CodeAnt PR Risk

🟢  Low Risk

• The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 26e5340ecdf0

[codecov]

Codecov Report

❌ Patch coverage is 71.11111% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.38%. Comparing base (2350348) to head (26e5340).
⚠️ Report is 58 commits behind head on master.

Files with missing lines	Patch %	Lines
superset-frontend/src/pages/Home/index.tsx	59.37%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #45589      +/-   ##
==========================================
- Coverage   84.63%   84.38%   -0.26%     
==========================================
  Files        3069     3069              
  Lines      205446   202493    -2953     
  Branches    48306    47641     -665     
==========================================
- Hits       173879   170871    -3008     
- Misses      28277    28380     +103     
+ Partials     3290     3242      -48     

Flag	Coverage Δ
javascript	80.82% <71.11%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	0759172
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6ae2c35584428dd4b3b28daa
😎 Deploy Preview	https://deploy-preview-45589--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[sadpandajoe]

LGTM

[sadpandajoe]

@rusackas PR says:

See #39528 for before/after screenshots.

but that PR doesn't have screenshots either. Mind adding them to your PR?

[SBIN2010]

LGTM!
I don’t think screenshots will provide the full picture here. You really need a video.

[rusackas]

Quick update for anyone waiting on the updated demo video.

While putting together a Playwright recording covering all three tabs (Favorite/Mine/All) for both Dashboards and Charts, one run appeared to show a dashboard's Recents entry surviving 15+ seconds after deleting it from the Mine tab - which would have meant this fix doesn't actually work in that case. That capture environment had accumulated a lot of cruft (orphaned processes, a possibly-stale webpack bundle), so before touching any code I ran a from-scratch repro instead: fresh SQLite DB, fresh migrations, fresh backend + webpack dev server, nothing left over from prior runs. It could not reproduce the staleness - the Recents entry disappeared immediately on every tab, for both dashboards and charts.

That matches what the code shows: LogDAO.get_recent_activity correctly excludes soft-deleted items, the /recent_activity/ response carries no caching headers, and onActivityRefresh fires regardless of which tab triggered the delete. So the original capture's staleness looks like an artifact of that environment, not a real bug.

To make sure this stays pinned down, I added playwright/tests/home/recent-activity-refresh.spec.ts, covering all six combinations of {Favorite, Mine, All} x {Dashboards, Charts}. All six pass cleanly against a clean environment.

Still finishing up a cleaner demo video (readable fixture names instead of the long IDs in the current one) - will post it here once it's ready.