[SPARK-53618][SQL] Turn a FULL JOIN with a false condition into a UNION ALL - #58506
Open
tokoko wants to merge 1 commit into
Open
[SPARK-53618][SQL] Turn a FULL JOIN with a false condition into a UNION ALL#58506tokoko wants to merge 1 commit into
tokoko wants to merge 1 commit into
Conversation
Member
|
seems like the PR title was truncated. Can you make it complete please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PropagateEmptyRelationalready rewrites a join whose condition isFalseLiteralfor most join types: inner/cross and left semi collapse to an empty relation for example. This PR addsFullOuterhandling. With a false condition no row on either side can find a match, so the join is equivalent to a UNION ALL of both sides, each padded with nulls for the other side's columns.Why are the changes needed?
1 = 0 is not an equi-join condition, so today this plan runs as a BroadcastNestedLoopJoin which is inefficient. After the rewrite both sides are scanned once and fuse into a single whole-stage codegen stage, with no exchange.
Users can usually write the union themselves, but not always. The motivating case is a MERGE with an intentionally non-matching condition, where the join is generated by the MERGE rewrite rather than written by hand:
This is the shape for a replaceWhere-style operation made possible by #52185.
Does this PR introduce any user-facing change?
No. Query results are unchanged; only the optimized plan changes.
How was this patch tested?
New and updated unit tests.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code 2.1.259 (Claude Opus 5)