[MINOR][NETWORK] Use system default trust managers in SSLFactory when truststore is missing - #56089
Closed
RinZ27 wants to merge 1 commit into
Closed
[MINOR][NETWORK] Use system default trust managers in SSLFactory when truststore is missing#56089RinZ27 wants to merge 1 commit into
RinZ27 wants to merge 1 commit into
Conversation
RinZ27
changed the title
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Author
|
I have updated the branch with the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactored
SSLFactory.javato replace the insecurecredulousTrustStoreManagersfallback with the JVM's defaultTrustManagerFactory. When a truststore is not explicitly provided, the system now correctly utilizes the standard system trust managers instead of blindly trusting all certificates.Why are the changes needed?
The previous implementation defaulted to a "trust-all" behavior if a truststore was missing or misconfigured. This silent security failure left internal Spark networking (RPC, Shuffle) vulnerable to Man-in-the-Middle (MITM) attacks. Aligning with standard Java security practices ensures robust certificate validation is maintained by default.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added a new unit test case
testBuildWithoutTrustStoreUsesSystemDefaultinSSLFactorySuite.javato verify successful engine initialization without a specific truststore. Verified all existing tests inSSLFactorySuitepass as expected.Was this patch authored or co-authored using generative AI tooling?
No.