[MINOR] [CORE] [TESTS] Fix flaky DAGSchedulerSuite test for push-based shuffle#55221
Closed
dbtsai wants to merge 2 commits intoapache:masterfrom
Closed
[MINOR] [CORE] [TESTS] Fix flaky DAGSchedulerSuite test for push-based shuffle#55221dbtsai wants to merge 2 commits intoapache:masterfrom
dbtsai wants to merge 2 commits intoapache:masterfrom
Conversation
Add sc.listenerBus.waitUntilEmpty() before the completedStage assertion to ensure the async listener bus has processed the stage completion event before we check it. Co-authored-by: DB Tsai <dbtsai@dbtsai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
sc.listenerBus.waitUntilEmpty()before thecompletedStageassertion in the push-based shuffle test inDAGSchedulerSuite.Why are the changes needed?
The test was intermittently failing due to a race condition.
SparkListenerStageCompletedevents are delivered asynchronously through thelistener bus, so the
completedStageassertion could execute before the event was processed, causing a spurious failure. Waiting for thelistener bus to drain before asserting eliminates the race.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test in
DAGSchedulerSuite. The fix removes a race condition rather than adding new test logic.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Sonnet 4.6 (Claude Code)