SOLR-18359: remove CreateTimeRoutedAlias.setMaxFutureMs(Integer) overload - #4781
Open
serhiy-bzhezytskyy wants to merge 1 commit into
Open
Conversation
…load Deprecated since 9.0 in favor of setMaxFutureMs(Long). The one caller (TimeRoutedAliasUpdateProcessorTest) already passes a Long, so it was already resolving to the non-deprecated overload -- zero real callers of the deprecated one.
Contributor
|
Looking again, does this mean there is an opportuntiyt to remove a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18359
Removes the deprecated
CollectionAdminRequest.CreateTimeRoutedAlias.setMaxFutureMs(Integer)overload, superseded bysetMaxFutureMs(Long)since SOLR-15376. Zero real callers of the deprecated overload -- the one call site (TimeRoutedAliasUpdateProcessorTest) already passes aLong.1 test, 0 failures (
testMaxFutureMs, gated behind-Dtests.awaitsfix=trueper its own@AwaitsFix(SOLR-13059)).AI-assisted (Claude Sonnet 5)