SOLR-18109: move SolrPluginUtils debug methods to DebugComponent - #4779
Open
serhiy-bzhezytskyy wants to merge 1 commit into
Open
SOLR-18109: move SolrPluginUtils debug methods to DebugComponent#4779serhiy-bzhezytskyy wants to merge 1 commit into
serhiy-bzhezytskyy wants to merge 1 commit into
Conversation
…tsDebug/doSimpleQuery to DebugComponent Resolves the file's own TODO: 'resolve duplicated code with DebugComponent. Perhaps it should be added to doStandardDebug?' -- these 4 methods were @deprecated with 'move to DebugComponent' since SOLR-17561, but never moved. Only 3 external call sites (2 in DebugComponent itself, 1 in MoreLikeThisHandler). Widened SolrPluginUtils.explanationsToStrings from private to public -- the only cross-package dependency the move needed, since it wasn't itself deprecated and stays a general-purpose utility.
Contributor
Author
|
cc @dsmiley -- you added the |
dsmiley
approved these changes
Aug 21, 2026
Contributor
There was a problem hiding this comment.
definitely not changelog worthy
epugh
approved these changes
Aug 21, 2026
epugh
left a comment
epugh
left a comment
Contributor
There was a problem hiding this comment.
LGTM. One question about the changelog...
| @@ -0,0 +1,7 @@ | |||
| title: Move the deprecated SolrPluginUtils.doStandardDebug, doStandardQueryDebug, doStandardResultsDebug, and doSimpleQuery to DebugComponent, where they now live as public static methods with the same signatures. | |||
| type: removed | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18109
Moves the four deprecated
SolrPluginUtilsdebug methods toDebugComponent-- resolves the file's own TODO: "resolve duplicated code with DebugComponent. Perhaps it should be added to doStandardDebug?" They were@Deprecated // move to DebugComponentsince SOLR-17561 but never actually moved.Per Eric's comments on the ticket, included all four together (
doStandardDebug,doStandardQueryDebug,doStandardResultsDebug,doSimpleQuery), not just the first one. Only 3 external call sites: 2 already inDebugComponentitself (now local calls, no prefix needed), 1 inMoreLikeThisHandler(updated, TODO removed). WidenedSolrPluginUtils.explanationsToStringsfromprivatetopublic-- the one cross-package dependency the move needed, since it isn't itself deprecated and stays a general-purpose utility inSolrPluginUtils.26 tests, 0 failures (DebugComponentTest, DistributedDebugComponentTest, MoreLikeThisHandlerTest, MoreLikeThisComponentTest, SolrPluginUtilsTest).
AI-assisted (Claude Sonnet 5)