SOLR-18149: un-deprecate ClusterState.createFromJson - #4777
Open
serhiy-bzhezytskyy wants to merge 1 commit into
Open
SOLR-18149: un-deprecate ClusterState.createFromJson#4777serhiy-bzhezytskyy wants to merge 1 commit into
serhiy-bzhezytskyy wants to merge 1 commit into
Conversation
The only reason it was deprecated (SOLR-17561) was 'doesn't support legacy configName location' -- David Smiley confirmed on the ticket that this is a Solr 8 concern, not relevant from 9 forward, and no such legacy-location code path exists anywhere in the current parsing. No behavior change; the caveat was already dead documentation.
dsmiley
requested changes
Aug 21, 2026
dsmiley
left a comment
dsmiley
left a comment
Contributor
There was a problem hiding this comment.
no; this should be removed not un-deprecated. Please offer an explanation as to why it should stay if you disagree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18149
Un-deprecates
ClusterState.createFromJsoninstead of removing it. The only reason it was deprecated (SOLR-17561) was "doesn't support legacy configName location" -- confirmed on the ticket that this is a Solr 8 concern, not relevant from 9 forward, and no such legacy-location code path exists anywhere in the current parsing. No behavior change; the caveat was already dead documentation.3 tests, 0 failures.
AI-assisted (Claude Sonnet 5)