Skip to content

SLING-13253 - upgrade JGit to 7.7.1 - #47

Merged
royteeuwen merged 1 commit into
masterfrom
feature/SLING-13253-upgrade-jgit
Aug 7, 2026
Merged

royteeuwen merged 1 commit into
masterfrom
feature/SLING-13253-upgrade-jgit

Conversation

@royteeuwen

@royteeuwen royteeuwen commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Stack: 1 of 3 — this is the bottom; #40 and #48 build on it.

Upgrades JGit from the 5.13.x line to 7.7.1.

The 5.13.x line is JGit's Java 8 maintenance branch and has no shallow clone support (CloneCommand.setDepth does not exist there). #48 needs it to clone only the tip of the site repository instead of its full history — ~25 MB rather than ~380 MB.

Two things beyond the version bump are required, both found by running the built image rather than by compiling:

  • commons-codec is declared in the feature. JGit 7 imports org.apache.commons.codec.digest in range [1.15,2); Maven had mediated the transitive version down to 1.11, below that range, and the feature did not list it at all.
  • java.management is added to the jlink module list. JGit 7 imports javax.management, which the trimmed JRE did not include. Without it the bundle fails to resolve and the CLI silently does nothing — it looks like a hang rather than an error.

Verified independently of the rest of the stack: builds and passes the full suite on its own (144 tests), and all 14 commands resolve and run in the rebuilt image.

The 5.13.x line the project tracks is the Java 8 maintenance branch and has no
shallow clone support, which the website update needs to avoid cloning the
site's full history.

JGit 7 additionally imports org.apache.commons.codec.digest, which Maven had
mediated down to a version below the range it requires, so commons-codec is
declared explicitly, and javax.management, which the jlink'd JRE did not
include - without that module the bundle silently fails to resolve and the CLI
does nothing at all.
@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

@royteeuwen
royteeuwen marked this pull request as ready for review August 7, 2026 15:23
@royteeuwen
royteeuwen merged commit 9d8b3a3 into master Aug 7, 2026
3 checks passed
@royteeuwen
royteeuwen deleted the feature/SLING-13253-upgrade-jgit branch August 7, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant