SLING-13289 - Push Sling Committer CLI image to DockerHub - #41
Merged
Conversation
rombert
commented
Aug 5, 2026
rombert
commented
Contributor
- configure GitHub action to push to DockerHub
- allow multi-arch builds
- set image to apache/sling-committer-cli as it better reflects its purpose as compared to apache/sling-cli
- updated documentation
- configure GitHub action to push to DockerHub - allow multi-arch builds - set image to apache/sling-committer-cli as it better reflects its purpose as compared to apache/sling-cli - updated documentation
rombert
force-pushed
the
issue/SLING-13289
branch
from
August 5, 2026 15:55
c3f4005 to
b620106
Compare
royteeuwen
requested changes
Aug 8, 2026
also allow manually triggering the action
- run the build in package phase (more idiomatic Maven IMO) - explicitly invoke docker:push in github actions - we don't want to run deploy in GH actions - install is too early IMO - remove docker.skip.push setting, no longer needed
|
Contributor
Author
|
Thanks for the thorough review @royteeuwen . I think I addressed all commments, please check. |
royteeuwen
approved these changes
Aug 14, 2026
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.