Skip to content

Skip JSON serialization for String data in SSE event stream #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lww97 wants to merge 1 commit into
base: 2.9.x
Choose a base branch
from
+3 −1
Open

Skip JSON serialization for String data in SSE event stream #5127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...in/java/org/apache/servicecomb/common/rest/codec/produce/ProduceEventStreamProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,10 @@ private void appendData(StringBuilder eventBuilder, List<?> datas) throws Except
throw new Exception("sse response data is null!");
}
for (Object data : datas) {
String value = data instanceof String ? (String) data
: RestObjectMapperFactory.getRestObjectMapper().writeValueAsString(data);
eventBuilder.append("data: ")
.append(RestObjectMapperFactory.getRestObjectMapper().writeValueAsString(data))
.append(value)
.append("\n");
}
}
Expand Down
Loading