[GH-2830] Adds Geography dual-dispatch to ST_GeometryType#2850
Merged
jiayuasu merged 4 commits intoapache:masterfrom Apr 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Geography support to the existing ST_GeometryType Spark SQL expression via dual-dispatch, returning ST_<JTSGeometryType> strings consistently for both Geometry and Geography inputs.
Changes:
- Add Geography implementation for
geometryTypeincommon("ST_" + toJTS(g).getGeometryType()). - Update Spark SQL
ST_GeometryTypeexpression to dispatch to Geometry or Geography functions based on input type. - Add unit/integration tests plus new Geography SQL docs entry for
ST_GeometryType.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala | Enable dual-dispatch for ST_GeometryType to support Geography inputs. |
| common/src/main/java/org/apache/sedona/common/geography/Functions.java | Add Geography geometryType implementation delegating through JTS. |
| common/src/test/java/org/apache/sedona/common/Geography/FunctionTest.java | Add Geography unit tests for geometryType (including null handling). |
| spark/common/src/test/scala/org/apache/sedona/sql/geography/GeographyFunctionTest.scala | Add Spark SQL integration tests for Geography ST_GeometryType. |
| docs/api/sql/geography/Geography-Functions.md / docs/api/sql/geography/Geography-Functions/ST_GeometryType.md | Document Geography ST_GeometryType and add it to the function index. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…upport.st_geometrytype
jiayuasu
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes #<issue_number>What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?