Skip to content

refactor: unify async synchronization with AsyncBand #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 2 commits into from
Sep 8, 2026
Merged

refactor: unify async synchronization with AsyncBand #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3001478
perf(azure-storage): coalesce user delegation key requests
tisonkun Sep 8, 2026
532a462
refactor: use AsyncBand for remaining async synchronization
tisonkun Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion context/http-send-reqwest/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ reqwest = { workspace = true, default-features = false, features = [
wasm-bindgen-test = { version = "0.3" }

[target.'cfg(target_arch = "wasm32")'.dependencies]
futures-channel = { version = "0.3" }
asyncband = { workspace = true, features = ["oneshot"] }
wasm-bindgen-futures = { version = "0.4" }

[target.'cfg(not(target_arch = "wasm32"))'.dev-dependencies]
Expand Down
4 changes: 2 additions & 2 deletions context/http-send-reqwest/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@
//! // Use the custom client
//! let http_send = ReqwestHttpSend::new(client);
//! ```
use bytes::Bytes;
#[cfg(target_arch = "wasm32")]
use futures_channel::oneshot;
use asyncband::oneshot;
use bytes::Bytes;
#[cfg(not(target_arch = "wasm32"))]
use http_body_util::BodyExt;
use reqsign_core::{Error, HttpSend, Result};
Comment thread
tisonkun marked this conversation as resolved.
Expand Down
3 changes: 3 additions & 0 deletions core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ rsa = { workspace = true, optional = true }
serde = { workspace = true, optional = true }
serde_json = { workspace = true, optional = true }

[dev-dependencies]
asyncband = { workspace = true, features = ["oneshot"] }

[target.'cfg(target_os = "windows")'.dependencies]
windows-sys = { version = "0.61.0", features = [
"Win32_Foundation",
Expand Down
2 changes: 1 addition & 1 deletion core/src/signer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ mod tests {
use super::*;
use crate::time::Timestamp;
use crate::{ErrorKind, ProvideCredential, SignRequest};
use futures::channel::oneshot;
use asyncband::oneshot;
use futures::future::{join_all, pending};
use futures::poll;
use http::{HeaderValue, Method, Request, Version};
Expand Down
2 changes: 2 additions & 0 deletions services/azure-storage/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ rust-version.workspace = true

[dependencies]
anyhow = { workspace = true }
asyncband = { workspace = true, features = ["singleflight"] }
base64 = { workspace = true }
bytes = { workspace = true }
form_urlencoded = { workspace = true }
Expand All @@ -45,6 +46,7 @@ rsa = { workspace = true }
reqsign-core = { workspace = true, features = ["jwt"] }

[dev-dependencies]
asyncband = { workspace = true, features = ["semaphore"] }
env_logger = { workspace = true }
reqsign-command-execute-tokio = { workspace = true }
reqsign-file-read-tokio = { workspace = true }
Expand Down
Loading
Loading