Repository navigation
RATIS-1562. Avoid sending install snapshot notifications and heartbets every round trip - #1690
Open
Elia-Renzoni wants to merge 1 commit into
Open
Elia-Renzoni wants to merge 1 commit into
Elia-Renzoni wants to merge 1 commit into
Conversation
…ts every round trip Signed-off-by: Elia Renzoni <elia.renzoni03@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before this PR, when
installSnapshotEnabled=false, the leader sent progress notifications and heartbeats too often, which meant far more RPCs than needed. With this PR, once a follower is installing a snapshot and replies IN_PROGRESS, both progress notifications and heartbeats are throttled, so the leader sends at most one per heartbeat interval.What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/RATIS/issues/RATIS-1562?filter=allopenissues
How was this patch tested?
unit test