Repository navigation
RATIS-2805. GrpcUtil: shutdownManagedChannels vs shutdownManagedChannel subtle differences. - #1686
Merged
Merged
Conversation
…el subtle differences. Assisted by claude-opus-5-5
amaliujia
reviewed
Nov 7, 2026
amaliujia
left a comment
amaliujia
left a comment
Contributor
There was a problem hiding this comment.
LGTM for the shutdown utils. Have a question for the security utils.
| } | ||
| } | ||
|
|
||
| static SslContextBuilder initSslContextBuilderForServer(KeyManagerConf keyManagerConfig) { |
Contributor
There was a problem hiding this comment.
We drop these code because they are not used or we have better replacement?
Contributor
Author
There was a problem hiding this comment.
These code are duplicated in NettyUtils.
amaliujia
approved these changes
Nov 7, 2026
Contributor
Author
|
@amaliujia , thanks for reviewing and merging this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See RATIS-2805
Assisted by claude-opus-5-5
Also removed duplicated methods.