Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RANGER-5858: return constraints (RANGER-5848) in the authz API result, so PDP and authz API callers such as the Agent Harness receive constraints like
requireApproval.RangerAuthzResult.ConstraintResult:name,parameters,policy(id, version),policyPriority.constraintsonResultInfoandPermissionResult, next todataMaskandrowFilter; each permission and sub-resource result carries its own. Left out of the JSON when empty.RangerAuthzPlugincopiesRangerAccessResult.getConstraints()into the result when access is allowed, sorted withRangerConstraintResult.CONSTRAINT_RESULT_COMPARATOR. No constraints are returned on deny or when access is not determined.authz-apidoes not depend on agents-common types, so the match type is not returned.The policy engine populates constraints only after RANGER-5842, so until then the response doesn't change.
Not in this change: the caller declaring supported constraints and deny-if-unsupported , and audit.
How was this patch tested?
TestRangerAuthzResult(authz-api):PermissionResultcopies constraints fromResultInfo; equals and hashCode include them;ConstraintResultaccessors and equality.TestRangerAuthzPluginConstraints(authz-embedded):RangerAuthzResultwith constraints, and the field omitted when empty.mvn -pl authz-api,authz-embedded -am checkstyle:check test