fix: omit null LOAD_TABLE_RESPONSE on conditional loadTable after-event - #5638
Merged
Merged
Conversation
dimas-b
previously approved these changes
Sep 28, 2026
dimas-b
left a comment
dimas-b
left a comment
Contributor
There was a problem hiding this comment.
Nice catch, @vigneshio ! Changes LGTM 👍 Thanks!
adutra
previously approved these changes
Sep 29, 2026
jbonofre
self-requested a review
September 29, 2026 09:13
jbonofre
previously approved these changes
Sep 29, 2026
jbonofre
left a comment
jbonofre
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks @vigneshio!
Omitting LOAD_TABLE_RESPONSE on HTTP 304 responses while adding the null-safety check in PolarisPersistenceEventListener provides good defense-in-depth.
NB: the CI failure is an unrelated flaky test recently introduced in #5504, I will take a look.
jbonofre
dismissed stale reviews from adutra, dimas-b, and themself
via
September 29, 2026 09:28
f1d534f
jbonofre
force-pushed
the
fix/load-table-304-after-event
branch
from
September 29, 2026 09:38
f1d534f to
81d8a33
Compare
jbonofre
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditional
loadTable(If-None-Matchmatch → HTTP 304notModified()with no entity) no longer attaches a nullLOAD_TABLE_RESPONSEto theAFTER_LOAD_TABLEevent. The persistence event listener also skips null attribute values while pruning, so a null response attribute cannot NPE.